[PATCH] D34907: fix ODR violations due to abuse of LLVM_YAML_IS_(FLOW_)?SEQUENCE_VECTOR

Zachary Turner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 30 13:51:34 PDT 2017

zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

I don't have any comments, this seems fine to me.  Long term I think the best solution is to get rid of these global specializations entirely, and instead provide adapters called `flow` and `block`, and instead of just saying `IO.mapOptional("Foo", Sequence);` and having it be picked up by a specialization, you would say `IO.mapOptional("Foo", flow(Sequence));`



More information about the cfe-commits mailing list