[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

This appears to affect our behavior under the MS ABI. We still seem to use this logic from CGVTables, even though that code is primarily Itanium related. In http://crbug.com/738468 we're seeing the LNK4102 linker warning, which says: "export of deleting destructor (name); image may not run correctly". You might want to take a look at that warning and reconsider whether this is something you want to do or not. MSVC makes it possible to allocate objects in different DLLs with different allocators, pass them across DLL boundaries, and deallocate them correctly if they are deleted through the vtable.

I'm going to revert for now to fix things.


Repository:
  rL LLVM

https://reviews.llvm.org/D34850