r304207 - Allow for unfinished #if blocks in preambles

Erik Verbruggen via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 30 07:31:44 PDT 2017

> On 23. Jun 2017, at 23:54, Richard Smith <richard at metafoo.co.uk> wrote:
> On 23 June 2017 at 13:34, Benjamin Kramer via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>> wrote:
> Since this change went in I'm seeing spurious errors whenever editing
> a header file, filed https://bugs.llvm.org/show_bug.cgi?id=33574 <https://bugs.llvm.org/show_bug.cgi?id=33574> for
> that.
> Does fixing the reversed condition I pointed out fix that?

Nope. See https://reviews.llvm.org/D34882 <https://reviews.llvm.org/D34882> for a fix that passes the case mentioned in the bug report. I asked Benjamin on IRC if he could test that patch a bit. Will polish it up when it's I know if it introduces more/other problems.

-- Erik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170630/a603cd6f/attachment.html>

More information about the cfe-commits mailing list