[PATCH] D34440: [Clang] Expand response files before loading compilation database

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 30 02:52:20 PDT 2017

alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.

Please re-upload the patch with full context (see http://llvm.org/docs/Phabricator.html).

Comment at: lib/Tooling/CommonOptionsParser.cpp:119
+  //Expand response files before loading compilation database from command line
+  SmallVector<const char *, 20> newArgv(argv, argv + argc);
Add a space after `//` and a trailing period.

Comment at: unittests/Tooling/CommonOptionsParserTest.cpp:69
\ No newline at end of file

Please fix the `No newline at end of file`.



More information about the cfe-commits mailing list