[PATCH] D34810: [Sema] -Wcomma should not warn for expressions that return void

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 30 02:08:17 PDT 2017

arphaman added a comment.

Ah, I see, so this is more of a stylistic warning rather than "suspicious" use one.

In https://reviews.llvm.org/D34810#795926, @rtrieu wrote:

>   What is the reason to exclude void expressions now?  For the function case, it is more consistent to warn on all function calls since we can't determine if a function returns void just by looking at the call site.

We've had an issue with -Wcomma adoption internally and have thought that this was a bug.



More information about the cfe-commits mailing list