[PATCH] D34329: [clang-diff] Initial implementation.

Johannes Altmanninger via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 29 09:36:16 PDT 2017


johannes marked 2 inline comments as done.
johannes added inline comments.


================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:439
+// Computes an optimal mapping between two trees.
+class ZsMatcher {
+  const ASTDiff::Impl &DiffImpl;
----------------
arphaman wrote:
> Do you know the reason for the `ZsMatcher` name? I noticed that they used it in the GumTree java implementation as well. If it's based on some paper you should add a comment that mentions it.
Ok, i forgot about that, it's Zhang and Shasha's algorithm for the tree edit distance, basically computing the Levenshtein distance for ordered trees.


https://reviews.llvm.org/D34329





More information about the cfe-commits mailing list