D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude <stdc-predef.h>

[Hahnfeld, Jonas via cfe-commits]

Hi,

-----Original Message-----
From: Blower, Melanie [mailto:melanie.blower at intel.com]
Sent: Thursday, June 29, 2017 5:35 AM
To: reviews+D34158+public+125da21f27579ee3 at reviews.llvm.org; 
zhangshengbin at huawei.com; olivier.jg at gmail.com; kalinichev.so.0 at gmail.com; 
kfunk at kde.org; mail at milianw.de; Keane, Erich <erich.keane at intel.com>; 
Hahnfeld, Jonas <Hahnfeld at itc.rwth-aachen.de>; mgorny at gentoo.org; 
fedor.sergeev at oracle.com; richard at metafoo.co.uk; renato.golin at linaro.org
Cc: cfe-commits at lists.llvm.org; klimek at google.com; simon.dardis at imgtec.com; 
anastasia.stulova at arm.com; arichardson.kde at gmail.com
Subject: RE: D34158: to support gcc 4.8 (and newer) compatibility on Linux, 
preinclude <stdc-predef.h>

[...]

================
Comment at: test/Driver/gcc-predef.c:9
+  #else
+    #if !defined(  _STDC_PREDEF_H )
+      #error "stdc-predef.h should be preincluded for GNU/Linux 4.8 and 
higher"
----------------
The driver will only include `stdc-predef.h` if it can be found in the system. 
With that, the current version of this test will only run on such Linux 
system. Maybe add a basic tree in `test/Driver/Inputs` and test that the 
corresponding header is included?
>>>OK I understand what you mean now.

To be clear here: I was thinking about running this test case on let's say 
Darwin/Mac OS X != GNU/Linux. But you probably figured that out of my 
imprecise comment already. Sorry about that.

Regards,
Jonas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5792 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170629/7926c0aa/attachment.bin>