[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Thanks, this looks good to me. Now if we could only figure out when aligned allocation is unavailable on other platforms this easily :)



================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6413
+  "if you supply your own aligned allocation functions, use "
+  "-Wno-aligned-allocation-unavailable to silence error/warning">;
 
----------------
How about "this diagnostic" instead of "error/warning"?


================
Comment at: include/clang/Driver/CC1Options.td:571
   
+def aligned_alloc_unavailable : Flag<["-"], "aligned-alloc-unavailable">,
+  HelpText<"Aligned allocation/deallocation functions are unavailable">;
----------------
`-faligned-alloc-unavailable` would be more consistent with other flags.


https://reviews.llvm.org/D34574