[PATCH] D34714: [MS] Don't statically initialize dllimport member function pointers
David Majnemer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 27 18:48:07 PDT 2017
majnemer added a comment.
In https://reviews.llvm.org/D34714#793205, @rnk wrote:
> Did you locally add a test case for the dllimport member function pointer template argument?
Arg, yes. Forgot to add the file...
Comment at: lib/Sema/SemaTemplate.cpp:5704
+ NPV = isNullPointerValueTemplateArgument(S, Param, ParamType, ResultArg);
> Think we should pass in Entity as an optional parameter to isNullPointerValueTemplateArgument to share the logic?
Seems reasonable, I'll give that a go.
More information about the cfe-commits