[PATCH] D34721: [PM] Add support for sample PGO in the new pass manager (clang-side)

Dehao Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 27 16:00:21 PDT 2017


danielcdh added inline comments.


================
Comment at: test/CodeGen/pgo-sample-thinlto-summary.c:4
+// RUN: %clang_cc1 -O2 -fexperimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO
+// RUN: %clang_cc1 -O2 -fexperimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2>&1 | FileCheck %s -check-prefix=THINLTO
 // Checks if hot call is inlined by normal compile, but not inlined by
----------------
This test will currently fail because PrepareForLLVM has not been passed down so that we do not know if it's in the thinlto compile phase.

Related discussion: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170626/464868.html

This patch needs to commit after that issue is fixed.


https://reviews.llvm.org/D34721





More information about the cfe-commits mailing list