[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: test/CodeGenObjCXX/arc-indirect.mm:19
+// CHECK-DARWIN: define internal void @"\01-[C object:struct:]"(<{ %0*, i8*, i8*, %struct.S, [3 x i8] }>* inalloca)
+// CHECK: %obj = getelementptr inbounds <{ %0*, i8*, i8*, %struct.S, [3 x i8] }>, <{ %0*, i8*, i8*, %struct.S, [3 x i8] }>* %0, i32 0, i32 2
----------------
You should CHECK for the load and appropriate call here. As written, this test would pass if you instead had changed the code to insert a null check.


https://reviews.llvm.org/D34580