[PATCH] D34206: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 26 07:55:40 PDT 2017

hokein added a comment.

In https://reviews.llvm.org/D34206#790406, @alexfh wrote:

> In https://reviews.llvm.org/D34206#783673, @hokein wrote:
> > In https://reviews.llvm.org/D34206#780455, @Eugene.Zelenko wrote:
> >
> > > It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for llvm::make_unique.
> >
> >
> > +1. See https://reviews.llvm.org/D34334, https://reviews.llvm.org/D34333. And found a few bugs in the check, will work on fixes on them.
> Ping me once you're done fixing the bugs.

I have a fix patch under review: https://reviews.llvm.org/D34286, and the other will come afterwards.

I think it is fine to check in this patch before these two bugs are fixed.


More information about the cfe-commits mailing list