[PATCH] D34299: [ubsan] Improve diagnostics for return value checks (clang)

Filipe Cabecinhas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 26 06:35:50 PDT 2017


filcab added a comment.

In https://reviews.llvm.org/D34299#788427, @vsk wrote:

> I hope I've cleared this up, but: we need to store the source location constant _somewhere_, before we emit the return value check. That's because we can't infer which return location to use at compile time.


Yes, sorry about that. I was thinking about the code the wrong way around. I'm ok with this patch and how it got in. Sorry for the delay in replying.


Repository:
  rL LLVM

https://reviews.llvm.org/D34299





More information about the cfe-commits mailing list