[PATCH] D34523: AST: mangle BlockDecls under MS ABI

[David Majnemer via Phabricator via cfe-commits]

majnemer added inline comments.


================
Comment at: lib/AST/MicrosoftMangle.cpp:993-994
+      Out << "YAX";
+      // struct __block_literal *
+      Out << "PA";
+      mangleArtificalTagType(TTK_Struct,
----------------
compnerd wrote:
> majnemer wrote:
> > Shouldn't we also mangle an 'E' in here on 64-bit platforms?
> I suppose that the default handling in x86_64 would give that.  I don't have a strong enough opinion on that.  I can add that if you think it makes a difference.
It is consistent with other pointer manglings; I think it'd be best to mangle pointer types as being 64-bit consistently.


Repository:
  rL LLVM

https://reviews.llvm.org/D34523