[PATCH] D34329: [GSoC] Clang AST diffing

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 23 07:45:09 PDT 2017


arphaman added inline comments.


================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:730
+
+Mapping TreeComparator::matchTopDown() const {
+  PriorityList L1(T1);
----------------
Johannes, it seems to me that your implementation of the top-down portion of the GumTree algorithm doesn't use the `an empty list A of candidate mappings` that's described in the paper (and that you have in the Python prototype). Is that correct or am I missing something?


https://reviews.llvm.org/D34329





More information about the cfe-commits mailing list