[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

Marc-Andre Laperle via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 21 12:44:30 PDT 2017

malaperle-ericsson added inline comments.

Comment at: clangd/ClangdUnit.cpp:276
+class DeclarationLocationsFinder : public index::IndexDataConsumer {
+  std::unique_ptr<std::vector<Location>> DeclarationLocations;
+  const SourceLocation &SearchedLocation;
ilya-biryukov wrote:
> Why do we need to use `unique_ptr<vector<Location>>` here and in other places instead of `vector<Location>`? 
It was to implement "takeLocations". Calling it claims ownship of the vector. Did you have something else in mind when you suggested to implement takeLocations with a std::move? Disclaimer: this c++11 stuff is all new to me so I wouldn't be surprised if I'm doing it in a terrible way.


More information about the cfe-commits mailing list