[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 21 08:31:45 PDT 2017


arphaman added a comment.

Thanks for the fix! The implementation looks correct. A couple of misc comments:

- Please move the test to `test/Index` (Since it uses `c-index-test`).
- In the future please upload patches with full context (`git diff -U9999`).



================
Comment at: lib/Sema/SemaDeclCXX.cpp:3771
+          TInfo = Context.CreateTypeSourceInfo(BaseType);
+          DependentNameTypeLoc TL = TInfo->getTypeLoc().castAs<DependentNameTypeLoc>();
+          if (!TL.isNull()) {
----------------
This line violates the 80 columns. Please use clang-format!


https://reviews.llvm.org/D32439





More information about the cfe-commits mailing list