[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

Ivan Donchevskii via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 19 23:34:58 PDT 2017

yvvan added a comment.

In https://reviews.llvm.org/D34279#784089, @hans wrote:

> I have 19.00.24210, so slightly earlier I suppose, but I believe we use Update 3 on our Chromium buildbots, and they seem happy.
> Can you paste the full error message? The part I see in your screenshot doesn't really make sense. Why should converting 1 to unsigned int be a narrowing conversion? I'm just trying to understand why we need this.

You can look at the file from screenshot and line numbers inside it - there's an implicit conversion from the enumeration TargetOpcode (which is signed int for my compiler without my change) to the unsigned int.


More information about the cfe-commits mailing list