[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros
Alexander Shaposhnikov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 19 12:19:51 PDT 2017
alexshap marked 3 inline comments as done.
alexshap added inline comments.
Comment at: lib/Edit/EditedSource.cpp:80
+ return ArgUse.Identifier == U.Identifier &&
+ std::tie(ArgUse.ExpansionStack, ArgUse.Use) !=
+ std::tie(U.ExpansionStack, U.Use);
> Do you need to compare the entire expansion stack, or can you get away with just the comparison of the front of the stack?
yeah, you are right, we can compare only the fronts because the entire stack can be recovered from that (via calling SourceMgr.getImmediateExpansionRange - like what's going on inside EditedSource::deconstructMacroArgLoc)
More information about the cfe-commits