[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 19 11:11:46 PDT 2017

arphaman added inline comments.

Comment at: include/clang/Edit/EditedSource.h:50
+    // Location of argument use inside the top-level macro
+    SourceLocation Use;
I think a name like `UseLoc` is more appropriate.

Comment at: lib/Edit/EditedSource.cpp:80
+          return ArgUse.Identifier == U.Identifier &&
+                 std::tie(ArgUse.ExpansionStack, ArgUse.Use) !=
+                     std::tie(U.ExpansionStack, U.Use);
Do you need to compare the entire expansion stack, or can you get away with just the comparison of the front of the stack?



More information about the cfe-commits mailing list