[PATCH] D33383: [GSoC] Flag value completion for clang

Rui Ueyama via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 19 09:59:29 PDT 2017

ruiu added inline comments.

Comment at: clang/include/clang/Driver/Options.td:496
 def cl_std_EQ : Joined<["-"], "cl-std=">, Group<opencl_Group>, Flags<[CC1Option]>,
-  HelpText<"OpenCL language standard to compile for.">;
+  HelpText<"OpenCL language standard to compile for.">, Values<"cl,CL,cl1.1,CL1.1,cl1.2,CL1.2,cl2.0,CL2.0">;
 def cl_denorms_are_zero : Flag<["-"], "cl-denorms-are-zero">, Group<opencl_Group>, Flags<[CC1Option]>,
v.g.vassilev wrote:
> I think we should have a way to express that the values are case insensitive, instead of enumerating all possible combinations.
Looks like this is not really a case-insensitive option, as it does not allow "cL2.0" for example. The enumerated values are exact list of values that the option accepts.


More information about the cfe-commits mailing list