[PATCH] D34329: [GSoC] Clang AST diffing

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 19 08:14:12 PDT 2017


arphaman added inline comments.


================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:277
+Mappings::~Mappings() {
+  delete[] SrcToDst;
+  delete[] DstToSrc;
----------------
Please use `std::unique_ptr<NodeId []>` for `SrcToDst` and `DstToSrc` as well and remove the destructor.


https://reviews.llvm.org/D34329





More information about the cfe-commits mailing list