[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 19 06:23:14 PDT 2017

mclow.lists added inline comments.

Comment at: src/experimental/filesystem/operations.cpp:27
+// We can use the presence of UTIME_OMIT to detect platforms that do not
+// provide utimensat, with some exceptions on OS X.
+#if !defined(UTIME_OMIT) ||                                                    \
Would it be easier to read if we split this test into two halves - one for Apple platforms and the other for the rest of the world?

    #if !defined(__APPLE__)
    # if !defined(UTIME_OMIT)
    # endif


More information about the cfe-commits mailing list