[PATCH] D34294: Rework libcxx strerror_r handling.
Kamil Rytarowski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 16 15:56:52 PDT 2017
krytarowski added a comment.
In https://reviews.llvm.org/D34294#782856, @jyknight wrote:
> In https://reviews.llvm.org/D34294#782806, @krytarowski wrote:
> > New one is harder to comprehend and less portable (usage of `__atribute__`).
> I can't disagree more strongly. This is fundamentally portable C++ code -- __attribute__((unused)) is simply warning suppression.
> I used it directly, because I saw other .cpp files in libcxx already did so. If it needs to be conditioned, it could be.
OK with me.
More information about the cfe-commits