[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 16 13:06:15 PDT 2017

phosek created this revision.

When -no-canonical-prefixes option is used and argv0 contains only
a program name, we need to do a PATH lookup to get an executable path,
otherwise the return value won't be a valid path and any subsequent
uses of it (e.g. invoking -cc1) will fail with an error.




Index: tools/driver/driver.cpp
--- tools/driver/driver.cpp
+++ tools/driver/driver.cpp
@@ -53,8 +53,15 @@
 using namespace llvm::opt;
 std::string GetExecutablePath(const char *Argv0, bool CanonicalPrefixes) {
-  if (!CanonicalPrefixes)
-    return Argv0;
+  if (!CanonicalPrefixes) {
+    SmallString<128> ExecutablePath(Argv0);
+    // Do a PATH lookup, if there are no directory components.
+    if (llvm::sys::path::filename(ExecutablePath) == ExecutablePath)
+      if (llvm::ErrorOr<std::string> P =
+              llvm::sys::findProgramByName(ExecutablePath))
+        ExecutablePath = *P;
+    return ExecutablePath.str();
+  }
   // This just needs to be some symbol in the binary; C++ doesn't
   // allow taking the address of ::main however.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34290.102861.patch
Type: text/x-patch
Size: 825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170616/a07c93ff/attachment.bin>

More information about the cfe-commits mailing list