[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 15 21:45:53 PDT 2017
dexonsmith added inline comments.
Comment at: src/experimental/filesystem/operations.cpp:22-24
> dexonsmith wrote:
> > I only just noticed you were including Availability.h. That shouldn't be necessary, since the macros should be defined by the compiler.
> __MAC_10_13 et al are defined in `Availability.h`, and `AvailabilityInternal.h` seems to do the `__ENV` dance described above. Are you sure it's not needed?
I don't think the dance is necessary, since libcxx won't be overriding those macros.
Also, we can skip the `__MAC_10_13` macros, ala src/chrono.cpp.
More information about the cfe-commits