[PATCH] D34262: [ubsan] PR33081: Skip the standard type checks for volatile

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 15 17:55:53 PDT 2017

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good, and I did ask Richard about this in person before filing the bug and he was in favor of it, so feel free to commit. If I'd known how easy it was to implement and how few tests it would break, I would've made the patch instead of filing it. :) Thanks for getting around to it.

Comment at: test/CodeGen/ubsan-volatile.c:9
+  // CHECK-NEXT: ret void
+  volatile int *p;
+  *p;
IMO the CHECKs would be cleaner if this were a parameter. You can do `CHECK-NOT: call{{.*}}ubsan` or something.


More information about the cfe-commits mailing list