[PATCH] D34091: Support for querying the exception specification type through libclang

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 15 14:27:14 PDT 2017

aaron.ballman added inline comments.

Comment at: include/clang-c/Index.h:213
+  /**
+   * \brief The exception specification has not yet been evaluated
+   */
This comment is now missing the full-stop at the end of the sentence (you dropped one too many periods).

Comment at: tools/libclang/CXType.cpp:693
+    if (const FunctionProtoType* FD = T->getAs<FunctionProtoType>()) {
+        return static_cast<int>(FD->getExceptionSpecType());
aaron.ballman wrote:
> Use `const auto *` and elide the braces.
You should run your patch through clang-format; the asterisk should bind to `FD` rather than `auto` and the indentation is too large in the patch.


More information about the cfe-commits mailing list