r305491 - LexerTest memory leak fix-

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 15 11:34:48 PDT 2017


Author: erichkeane
Date: Thu Jun 15 13:34:47 2017
New Revision: 305491

URL: http://llvm.org/viewvc/llvm-project?rev=305491&view=rev
Log:
LexerTest memory leak fix-

A new LexerTest unittest introduced a memory leak.  This patch
uses a unique_ptr with a custom deleter to ensure it is properly
deleted.

Modified:
    cfe/trunk/unittests/Lex/LexerTest.cpp

Modified: cfe/trunk/unittests/Lex/LexerTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Lex/LexerTest.cpp?rev=305491&r1=305490&r2=305491&view=diff
==============================================================================
--- cfe/trunk/unittests/Lex/LexerTest.cpp (original)
+++ cfe/trunk/unittests/Lex/LexerTest.cpp Thu Jun 15 13:34:47 2017
@@ -402,7 +402,9 @@ TEST_F(LexerTest, DontOverallocateString
       ArgTokens.push_back(tok);
   }
 
-  MacroArgs *MA = MacroArgs::create(MI, ArgTokens, false, *PP);
+  auto MacroArgsDeleter = [&PP](MacroArgs *M) { M->destroy(*PP); };
+  std::unique_ptr<MacroArgs, decltype(MacroArgsDeleter)> MA(
+      MacroArgs::create(MI, ArgTokens, false, *PP), MacroArgsDeleter);
   Token Result = MA->getStringifiedArgument(0, *PP, {}, {});
   EXPECT_EQ(tok::string_literal, Result.getKind());
   EXPECT_STREQ("\"\\\"StrArg\\\"\"", Result.getLiteralData());




More information about the cfe-commits mailing list