[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

Anna Zaks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 14 15:10:12 PDT 2017


zaks.anna added a comment.

Great cleanup! Some comments below.



================
Comment at: www/analyzer/alpha_checks.html:91
+(C, C++)</span><div class="descr">
+Check for logical errors for function calls and Objective-C message 
+expressions (e.g., uninitialized arguments, null function pointers, 
----------------
for function calls -> in function calls?
After briefly looking into this, the checker only reports the use of uninitialized arguments in calls, not the other issues (like null function pointers). Could you double check this?


================
Comment at: www/analyzer/alpha_checks.html:152
+(C, C++, ObjC)</span><div class="descr">
+Loss of sign/precision in implicit conversions</div></div></td>
+<td><div class="exampleContainer expandable">
----------------
sign/precision -> sign or precision


================
Comment at: www/analyzer/available_checks.html:1423
+(C)</span><div class="descr">
+<em>This checker isn't a independent checker, it is part of
+<code>unix.Malloc</code> with configuration option
----------------
I cannot find MallocWithAnnotations checker. Also if it exists, it should not be on by default, it should be alpha.

(I do not know if anyone is using Optimistic=true and think we should just remove that mode..)


================
Comment at: www/analyzer/available_checks.html:1556
 <tr><td><div class="namedescr expandable"><span class="name">
+unix.StdCLibraryFunctions</span><span class="lang">
+(C, C++)</span><div class="descr">
----------------
I do not think we should list "modeling" checkers here.


https://reviews.llvm.org/D33645





More information about the cfe-commits mailing list