[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude <stdc-predef.h>
Melanie Blower via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 14 14:20:00 PDT 2017
mibintc updated this revision to Diff 102605.
mibintc added a comment.
Thanks for your review, Fedor. I moved AddGnuIncludeArgs out of GCCInstallation, like you suggested, and put it along where the library includes are added. I also pulled out the change for MipsLinux since I don't have a way to verify that.
I still have the same 7 test failures when make check-all on Linux. 3 of the fails are from "clangd" unit tests. Not sure why they are failing but i scanned the tests a little and it talks about access only to whitelisted directories, so I assume they aren't working because the dir where std-predef.h lives is not white listed. Maybe I should be sure that "file exists(stdc-predef.h)", e.g. using the system include path, before adding the -include into the command line--what do you think?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 23977 bytes
Desc: not available
More information about the cfe-commits