[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude <stdc-predef.h>

Fedor Sergeev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 13 12:35:05 PDT 2017

fedor.sergeev added inline comments.

Comment at: lib/Driver/ToolChains/Gnu.h:219-220
+    void AddGnuIncludeArgs(const llvm::opt::ArgList &DriverArgs,
+                          llvm::opt::ArgStringList &CC1Args) const;
To me this does not belong to GCC-Installation-Detector at all, as it does not have anything to do with detection.

As I see the only reason for adding it here is to check Version vs 4.8.0.
If thats true then adding getVersion() here and using it elsewhere seems a better solution.


More information about the cfe-commits mailing list