[PATCH] D33304: [clang-tidy][Part1] Add a new module Android and three new checks.

Yan Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 13 10:02:31 PDT 2017

yawanng added inline comments.

Comment at: docs/clang-tidy/checks/android-file-open-flag.rst:6
+A common source of security bugs has been code that opens file without using
+the ``O_CLOEXEC`` flag.  Without that flag, an opened sensitive file would
alexfh wrote:
> I'm not sure about using of "has been" here. Maybe just use present tense? You might want to consult a nearby native speaker though. Alternatively, you might want to rephrase this as "Opening files using POSIX ``open`` or similar system calls without specifying the ``O_CLOEXEC`` flag is a common source of security bugs."
I copied these sentences from the requests written by a native speaker, I think. But after talking with another native speaker, yes, present tense seems to be better here. Thanks :)


More information about the cfe-commits mailing list