[PATCH] D34148: [clangd] Store references instead of unique_ptrs in ClangdServer.

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 13 08:21:06 PDT 2017

krasimir added inline comments.

Comment at: clangd/ClangdLSPServer.h:75
+  LSPDiagnosticsConsumer DiagConsumer;
+  RealFileSystemProvider FSProvider;
This approach is still inflexible. I'd make ClangdLSPServer : public DiagnosticsConsumer and pass references to the CompilationDatabase and to the FileSystemProvider to its constructor. I'd create these two in ClangdMain.cpp.


More information about the cfe-commits mailing list