[PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 12 23:08:20 PDT 2017


dblaikie added a comment.

I take it there's already handling for these attributes on non-member functions?

There's probably a reason this code can't be wherever that code is & subtract one from the index? (reducing code duplication by having all the error handling, etc, in one place/once)


https://reviews.llvm.org/D34052





More information about the cfe-commits mailing list