[PATCH] D33904: Add a __has_attribute_enhancement macro to clang

George Burgess IV via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 12 10:56:55 PDT 2017

george.burgess.iv added a comment.

> Why not just use __has_feature(overloadable_unmarked) or similar?

My impression was that `__has_feature` was was for larger features than tweaks to attributes. If this would be an appropriate use of `__has_feature`, though, I'm happy to keep things simple.

I'll update the other review with `__has_feature`. If it goes in with that, I'll abandon this.


Comment at: docs/LanguageExtensions.rst:176
+For example, clang's ``overloadable`` attribute has existed since before Clang
+3.5, but in Clang 5.0 it gained was modified to support so-called "unmarked
+overloads".  One can use ``__has_attribute_enhancement`` to query whether clang
ahatanak wrote:
> Do you need "gained" here?
Good catch :)


More information about the cfe-commits mailing list