[PATCH] D34102: [analyzer] Add portability package for the checkers.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 12 09:13:05 PDT 2017

NoQ added inline comments.

Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:454
+def UnixAPIPortabilityChecker : Checker<"API">,
+  HelpText<"Finds implementation-defined behavior in UNIX/Posix functions">,
+  DescFile<"UnixAPIChecker.cpp">;
zaks.anna wrote:
> Does this need to be in unix?
  1. the description still says "UNIX/Posix" and
  2. even if we believe that `malloc` isn't a UNIX/Posix-specific thing, we'd also need to move our `MallocChecker` out of the `unix` package.

This is probably the right thing to do, but i didn't try to do it here. If we want this, i'd move the portability checker out of `unix` now and deal with `MallocChecker` in another patch. I can also move the portability checker's code into `MallocChecker.cpp`, because that's what we always wanted to do, according to a `UnixAPIChecker`'s FIXME.


More information about the cfe-commits mailing list