[PATCH] D32480: clang-format: Add CompactNamespaces option

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 12 08:15:21 PDT 2017


klimek added a comment.

In https://reviews.llvm.org/D32480#773807, @Typz wrote:

> So how do I proceed?
>
> 1. Keep the CompactNamespace option, and make "compacted" namespaces always add at most one level of indentation
> 2. Or assume that this can only ever usefully work with the behavior of NI_None and add an additional enum value NI_Compact.


I'd vote for (1).

> And should we limit 'compacting' to namespace which start and end at consecutive lines [e.g. exactly the same conditions as C++17 nested namespaces], or is the current implementation enough [merge all adjacent beginning and all adjacent endings] ?

I'd vote for the former.


https://reviews.llvm.org/D32480





More information about the cfe-commits mailing list