[PATCH] D17143: [Sema] PR25156 Crash when parsing dtor call on incomplete type

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 9 17:39:32 PDT 2017


rjmccall added inline comments.


================
Comment at: lib/Sema/SemaExprCXX.cpp:192
     Found.clear();
-    if (Step == 0 && LookupCtx)
+    if (Step == 0 && LookupCtx && !RequireCompleteDeclContext(SS, LookupCtx))
       LookupQualifiedName(Found, LookupCtx);
----------------
You should probably respond to the incomplete context within this case (by returning nullptr, I guess) instead of falling down into the else.


https://reviews.llvm.org/D17143





More information about the cfe-commits mailing list