[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 8 10:12:14 PDT 2017


arphaman added inline comments.


================
Comment at: test/Index/availability.c:20
 // CHECK-2: (macos, introduced=10.4, deprecated=10.5, obsoleted=10.7)
 
 // CHECK-2: EnumConstantDecl=old_enum:6:3 (Definition) (deprecated)
----------------
rdwampler wrote:
> Can we run `FileCheck` once now? I believe the `CHECK-1` and `CHECK-2` were added since there were no particular order for the availabilities. With this patch the order is guarantee to be stable.
Sure, if the test passes we can use one `FileCheck` invocation. We can also use `CHECK-DAG:` to check for strings without obeying a specific order. 


https://reviews.llvm.org/D33478





More information about the cfe-commits mailing list