[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

don hinton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 6 18:36:15 PDT 2017


hintonda updated this revision to Diff 101659.
hintonda added a comment.
Herald added a subscriber: xazax.hun.

In order to fix diagnostic corruption in some of the buildbot tests
(unable to reproduce locally):

- make NoexceptMacro a static variable so it's lifetime doesn't end when UseNoexceptCheck is destroyed.

- pass a const char* instead of a StringRef to DiagnosticBuilder so it won't create a temporary std::string and cache the address of the temporary char * it owns.


https://reviews.llvm.org/D20693

Files:
  clang-tidy/modernize/CMakeLists.txt
  clang-tidy/modernize/ModernizeTidyModule.cpp
  clang-tidy/modernize/UseNoexceptCheck.cpp
  clang-tidy/modernize/UseNoexceptCheck.h
  docs/ReleaseNotes.rst
  docs/clang-tidy/checks/list.rst
  docs/clang-tidy/checks/modernize-use-noexcept.rst
  test/clang-tidy/modernize-use-noexcept-macro.cpp
  test/clang-tidy/modernize-use-noexcept-opt.cpp
  test/clang-tidy/modernize-use-noexcept.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20693.101659.patch
Type: text/x-patch
Size: 23881 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170607/e6ee7422/attachment-0001.bin>


More information about the cfe-commits mailing list