[PATCH] D33708: [test] [libcxx] Disable MSVC++'s compare(a, b) implies !compare(b, a) assertion in predicate application count tests

Billy O'Neal via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 5 12:41:14 PDT 2017


But I actually want the predicate count assertions turned on -- if a user
turns off iterator debugging they need to get exactly what the standard
asks for, and that means both predicate assertions like this and the
Iterator Debug Array Overloads go away.

I need to figure out how to do this with our test harness though, since at
the moment we depend on that forceinclude.

Billy3

On Mon, Jun 5, 2017 at 9:51 AM, David Blaikie <dblaikie at gmail.com> wrote:

> Alternatively, you could disable the check (or change the count it checks)
> if this is defined. (& if you disable the check when this is defined, you
> could change an existing build/test config (or add a new one) to have this
> disabled)
>
> On Tue, May 30, 2017 at 8:19 PM Billy Robert O'Neal III via Phabricator
> via cfe-commits <cfe-commits at lists.llvm.org> wrote:
>
>> BillyONeal abandoned this revision.
>> BillyONeal added a comment.
>>
>> Stephan pointed out that the force include breaks this. Backing it out
>> for now :(
>>
>>
>> https://reviews.llvm.org/D33708
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170605/04ba3186/attachment.html>


More information about the cfe-commits mailing list