[PATCH] D33788: Return a canonical path from getClangResourcePath()

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 2 11:57:28 PDT 2017


bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.



> Yes, but that does not canonicalize the path. For instance, it won't handle doubled-up slashes or symlinks.

Right.

> Ultimately, the value returned from this API gets passed to POSIX functions which expect a canonical path. I don't think `remove_dots()` is sufficient. It should do the same thing as `getMainExecutable()`, I believe.

I see, LGTM then


https://reviews.llvm.org/D33788





More information about the cfe-commits mailing list