[PATCH] D33304: [clang-tidy][Part1] Add a new module Android and three new checks.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 2 09:27:04 PDT 2017


alexfh added a comment.

In https://reviews.llvm.org/D33304#771215, @hokein wrote:

> Thanks for the contributions.
>
> All your three checks are not android specific -- because they are checking POSIX APIs (`open`, `creat`, `fopen`), which are more likely related to POSIX. So personally, I'm +1 on a "posix" module, instead of "android", but wait to see other reviewers' opinions before renaming it.


IIUC, these checks enforce a certain - Android-specific - way of using POSIX APIs. I'm not sure if the recommendations are universally useful. Or am I mistaken?


https://reviews.llvm.org/D33304





More information about the cfe-commits mailing list