[PATCH] D33357: Avoid calling report_fatal_error in the destructor of raw_fd_ostream when saving a module timestamp file

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 2 03:37:19 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL304538: Avoid calling report_fatal_error in the destructor of raw_fd_ostream (authored by arphaman).

Changed prior to commit:
  https://reviews.llvm.org/D33357?vs=99904&id=101182#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D33357

Files:
  cfe/trunk/lib/Serialization/ASTReader.cpp


Index: cfe/trunk/lib/Serialization/ASTReader.cpp
===================================================================
--- cfe/trunk/lib/Serialization/ASTReader.cpp
+++ cfe/trunk/lib/Serialization/ASTReader.cpp
@@ -3697,6 +3697,8 @@
   if (EC)
     return;
   OS << "Timestamp file\n";
+  OS.close();
+  OS.clear_error(); // Avoid triggering a fatal error.
 }
 
 /// \brief Given a cursor at the start of an AST file, scan ahead and drop the


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33357.101182.patch
Type: text/x-patch
Size: 440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170602/67ae74c2/attachment.bin>


More information about the cfe-commits mailing list