[PATCH] D33719: Add _Float16 as a C/C++ source language type

[Bruno Cardoso Lopes via Phabricator via cfe-commits]

bruno added a comment.

Hi Sjoerd,

Thanks for working on this. Can you add context to your patch?



================
Comment at: test/CodeGenCXX/float16-declarations-error.cpp:1
+// RUN: not %clang -S -emit-llvm --target=aarch64 %s -o - 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR
+
----------------
You don't need codegen to test this. Please move this test to test/Lexer, (see test/Lexer/half-literal.cpp).

Also, is `--target=aarch64` really needed here? I don't see anything ARM specific in this patch (maybe because I'm missing more context on the patch?).


================
Comment at: test/CodeGenCXX/float16-declarations.cpp:59
+    func1t(f1l) + s1.mem2 - f1n + f2n;
+#if (__cplusplus >= 201103L)
+  auto f5l = -1.f16, *f6l = &f2l, f7l = func1t(f3l);
----------------
Please use `-std=c++11` in the RUN line on top of the file and remove the `#if` here. Can you provide a more reduced testcase and try to put the CHECK lines closer to the statements you want to check? The same ARM question from the comment above also applies here.


https://reviews.llvm.org/D33719