[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

[Bruno Cardoso Lopes via Phabricator via cfe-commits]

bruno added a comment.

Hi Richard,

Thanks for improving this further!

Questions / comments:

- I've noticed in the patch that on the ASTWriter side we serialize the introduced size / mtime, but there are no changes to the ASTReader, so I assume in the reader side you still need the module map around to fetch those infos, right?
- Does this patch provide any benefits for the case where we don't provide a size / mtime for the header in the module map? Since Size / ModTime are only updated when parsing the module map I would assume no, but I might have missed something.



================
Comment at: include/clang/Basic/DiagnosticSerializationKinds.td:193
+  "cannot emit module %0: %select{size|mtime}1 must be explicitly specified "
+  "for missing header file \"%2\"">;
 } // let CategoryName
----------------
Can you add a testcase that test this error?


Repository:
  rL LLVM

https://reviews.llvm.org/D33703