[PATCH] D33741: [libc++] Undef min/max in test_macros.h

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added a comment.

In https://reviews.llvm.org/D33741#769371, @STL_MSFT wrote:

> I haven't seen min/max test failures, probably because our CRT/STL headers never drag in Windows.h.


Ah, that makes sense. Libc++ currently does although the plan is to fix that eventually. :-S

> I have no objection to undeffing min/max although I wouldn't do this myself (it creates order dependencies which I think are totally evil).

Yeah, the header order is super evil. Agreed.


https://reviews.llvm.org/D33741