[PATCH] D33398: Mangle __unaligned in Itanium ABI

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 12:37:59 PDT 2017


rsmith added a comment.

In https://reviews.llvm.org/D33398#769152, @rnk wrote:

> Isn't there a space in the mangling for vendor extensions? Can we use that here?


We are using that here: that's what `mangleVendorQualifier` does.



================
Comment at: lib/AST/ItaniumMangle.cpp:2210
+  if (Quals.hasUnaligned())
+      mangleVendorQualifier("__unaligned");
+
----------------
Too much indentation here. Also, the ABI requires the "unordered" vendor qualifiers to be emitted in reverse alphabetical order, so this should be emitted after `__weak` and `__strong` but before `__autoreleasing`.


https://reviews.llvm.org/D33398





More information about the cfe-commits mailing list