[PATCH] D33721: [ARM] Add support for target("arm") and target("thumb").

Javed Absar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 06:41:04 PDT 2017


javed.absar added a comment.





================
Comment at: include/clang/Basic/Attr.td:1774
+
+        // Convert GNU target names for arm and thumb to thumb-mode target
+        // feature.
----------------
Would this be a more accurate comment:

"...arm and thumb to thumb-mode" => "arm and thumb to arm-mode or thumb-mode, respectively"
Or 
"[-|+] thumb-mode"


https://reviews.llvm.org/D33721





More information about the cfe-commits mailing list